Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update docs for metadata propagation #6935

Merged
merged 1 commit into from
Jul 20, 2022
Merged

📖 Update docs for metadata propagation #6935

merged 1 commit into from
Jul 20, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Update the migration guide and a BoostrapConfigTemplateResource example to reflect changes to metadata propagation.

Fixes #5240

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2022
killianmuldoon
killianmuldoon commented Jul 15, 2022
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is pretty late coming - when it was proposed this was a v1alpha4->v1beta1 migration guide, which now been changed to a versioned 0.4->1.0 guide. I'm not sure if we want to backport it or surface the same information somewhere else.

@killianmuldoon killianmuldoon changed the title Update docs for metadata propagation 📖 Update docs for metadata propagation Jul 15, 2022
@killianmuldoon killianmuldoon force-pushed the docs/add-info-for-metadata-propagation branch from ee4e259 to bbb1b0e Compare July 15, 2022 16:00
@fabriziopandini
Copy link
Member

lgtm pending addressing comments

@killianmuldoon
Update docs for metadata propagation
c5ba19f 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon killianmuldoon force-pushed the docs/add-info-for-metadata-propagation branch from bbb1b0e to c5ba19f Compare July 19, 2022 15:51
chrischdi
chrischdi reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@enxebre
Copy link
Member

enxebre commented Jul 20, 2022

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@killianmuldoon
Copy link
Contributor Author

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 2e73a26 into kubernetes-sigs:main Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 20, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 20, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #6962

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre enxebre left review comments

@chrischdi chrischdi chrischdi left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Consistent metadata propagation behaviour
7 participants
@killianmuldoon @fabriziopandini @enxebre @k8s-ci-robot @k8s-infra-cherrypick-robot @chrischdi @sbueringer